Skip to content
/ CoreLibs Public
  • Notifications You must be signed in to change notification settings
  • Fork 7
  • Star 40
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content script is not injected if there is a tag (with embed attribute) before doctype declaration #1825

Closed
AdamWr opened this issue Nov 15, 2023 · 0 comments
Closed

Content script is not injected if there is a tag (with embed attribute) before doctype declaration #1825

AdamWr opened this issue Nov 15, 2023 · 0 comments
Assignees
@ngorskikh
Labels
Priority: P4 Resolution: Fixed Status: Closed Version: CoreLibs v1.14

Comments

@AdamWr
Copy link
Member

AdamWr commented Nov 15, 2023 •
edited
Loading

Steps to reproduce:

  1. Add these rules:
example.org##body
||example.org^$replace=/<!doctype html>/<tag embed="PHNjcmlwdCBzcmM9Imh0dHBzOi8vZXhhbXBsZS5vcmcvIiBhc3luYz0iYXN5bmMiPjwvc2NyaXB0Pg=="><\/tag><!doctype html>/
  1. Go to - https://example.org/

Website should be blank, but script is not injected, so element hiding rules do not work.

Screenshot with $replace rule enabled

image

Screenshot with $replace rule disabled

image

Real case is here - AdguardTeam/AdguardFilters#165930
It has been fixed by $replace rule, so to reproduce please add this rule:

@@||transfermarkt.com.tr^$replace=/<tm-consent[\s\S]*?<\/tm-consent>(<!DOCTYPE html>)/\$1/,document

to user rules.

AdGuard for Windows 7.15.0 nightly 28 (4460) (CL 1.13.79, DL 2.4.0 )
@adguard-bot adguard-bot assigned sfionov Nov 15, 2023
@adguard-bot adguard-bot added the Priority: P4 label Nov 15, 2023
@adguard-bot adguard-bot assigned grumaxxx and unassigned sfionov Dec 8, 2023
@adguard-bot adguard-bot added the Version: CoreLibs v1.14 label Dec 8, 2023
@adguard-bot adguard-bot assigned ngorskikh and unassigned grumaxxx Dec 27, 2023
@adguard-bot adguard-bot added Status: In Progress Resolution: Fixed Status: In Review Status: Resolved and removed Status: In Progress Status: In Review labels Dec 27, 2023
This was referenced Feb 5, 2024
Update CoreLibs to 1.14.16 AdguardTeam/AdguardForWindows#5032
Closed
Update CoreLibs to 1.14.16 AdguardTeam/AdguardForAndroid#5207
Closed
@sfionov sfionov mentioned this issue Feb 29, 2024
Update CoreLibs to 1.14.34 AdguardTeam/AdguardForMac#1390
Closed
@adguard-bot adguard-bot closed this as completed Mar 18, 2024
@adguard-bot adguard-bot added Status: Closed and removed Status: Resolved labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ngorskikh ngorskikh

Labels
Priority: P4 Resolution: Fixed Status: Closed Version: CoreLibs v1.14
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sfionov @AdamWr @adguard-bot @ngorskikh @grumaxxx

Footer

© 2024 GitHub, Inc.

玻璃钢生产厂家武陟玻璃钢雕塑设计上海绿色种植玻璃钢花盆湛江商场装饰玻璃钢雕塑优质的玻璃钢雕塑卡通人物雕像玻璃钢雕塑定做南京秦淮美陈商场广州商场美陈市场兰溪玻璃钢雕塑电话惠州玻璃钢花盆雕塑扬州美陈商场焦作市玻璃钢雕塑定制户外玻璃钢卡通雕塑宁夏玻璃钢商场美陈雕塑丽江玻璃钢雕塑直供玻璃钢雕塑修补流程常州仿石头玻璃钢花盆临江玻璃钢门头雕塑玻璃钢花盆如何做哪个牌子的玻璃钢雕塑泰兴玻璃钢雕塑铜陵人物玻璃钢雕塑生产厂玻璃钢雕塑ip雕塑实体工厂定制玻璃钢雕塑销售价格海口商场美陈值得信赖云南个性化玻璃钢雕塑定制河南商场玻璃钢花盆合肥卡通玻璃钢雕塑制作淮北玻璃钢雕塑制作公司翔安园林玻璃钢雕塑采购常见商场美陈费用香港通过《维护国家安全条例》两大学生合买彩票中奖一人不认账让美丽中国“从细节出发”19岁小伙救下5人后溺亡 多方发声单亲妈妈陷入热恋 14岁儿子报警汪小菲曝离婚始末遭遇山火的松茸之乡雅江山火三名扑火人员牺牲系谣言何赛飞追着代拍打萧美琴窜访捷克 外交部回应卫健委通报少年有偿捐血浆16次猝死手机成瘾是影响睡眠质量重要因素高校汽车撞人致3死16伤 司机系学生315晚会后胖东来又人满为患了小米汽车超级工厂正式揭幕中国拥有亿元资产的家庭达13.3万户周杰伦一审败诉网易男孩8年未见母亲被告知被遗忘许家印被限制高消费饲养员用铁锨驱打大熊猫被辞退男子被猫抓伤后确诊“猫抓病”特朗普无法缴纳4.54亿美元罚金倪萍分享减重40斤方法联合利华开始重组张家界的山上“长”满了韩国人？张立群任西安交通大学校长杨倩无缘巴黎奥运“重生之我在北大当嫡校长”黑马情侣提车了专访95后高颜值猪保姆考生莫言也上北大硕士复试名单了网友洛杉矶偶遇贾玲专家建议不必谈骨泥色变沉迷短剧的人就像掉进了杀猪盘奥巴马现身唐宁街 黑色着装引猜测七年后宇文玥被薅头发捞上岸事业单位女子向同事水杯投不明物质凯特王妃现身！外出购物视频曝光河南驻马店通报西平中学跳楼事件王树国卸任西安交大校长 师生送别恒大被罚41.75亿到底怎么缴男子被流浪猫绊倒 投喂者赔24万房客欠租失踪 房东直发愁西双版纳热带植物园回应蜉蝣大爆发钱人豪晒法院裁定实锤抄袭外国人感慨凌晨的中国很安全胖东来员工每周单休无小长假白宫：哈马斯三号人物被杀测试车高速逃费 小米：已补缴老人退休金被冒领16年 金额超20万

玻璃钢生产厂家 XML地图 TXT地图 虚拟主机 SEO 网站制作 网站优化